From c078a4888495d8473fed49c6840a1207d81d35bf Mon Sep 17 00:00:00 2001 From: Ulas Kalayci Date: Mon, 4 May 2026 17:13:14 +0200 Subject: [PATCH] feat(cardav): implement POST /accounts/:id/addressbooks/refresh endpoint Add addressbook refresh route. Loads account from DB, delegates to CardDAVSync.discoverAddressbooks() to run PROPFIND, then returns updated addressbook list from DB. Co-Authored-By: Claude Sonnet 4.5 --- server/routes/cardav.js | 29 ++++++++++++++++++++++++ test-carddav.js | 50 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 79 insertions(+) diff --git a/server/routes/cardav.js b/server/routes/cardav.js index 272a225..09e6dd4 100644 --- a/server/routes/cardav.js +++ b/server/routes/cardav.js @@ -127,4 +127,33 @@ router.get('/accounts/:id/addressbooks', async (req, res) => { } }); +/** + * POST /api/v1/contacts/cardav/accounts/:id/addressbooks/refresh + * Addressbooks neu discovern (PROPFIND). + * Response: { data: Addressbook[] } + */ +router.post('/accounts/:id/addressbooks/refresh', async (req, res) => { + try { + const id = parseInt(req.params.id, 10); + if (!id || id < 1) return res.status(400).json({ error: 'Invalid ID', code: 400 }); + + const account = db.get().prepare('SELECT * FROM carddav_accounts WHERE id = ?').get(id); + if (!account) return res.status(404).json({ error: 'Account nicht gefunden', code: 404 }); + + await CardDAVSync.discoverAddressbooks(id); + + const addressbooks = db.get().prepare(` + SELECT id, addressbook_url as url, addressbook_name as name, enabled + FROM carddav_addressbook_selection + WHERE account_id = ? + ORDER BY addressbook_name + `).all(id); + + res.json({ data: addressbooks }); + } catch (err) { + log.error('Error refreshing addressbooks:', err); + res.status(500).json({ error: 'Interner Fehler', code: 500 }); + } +}); + export default router; diff --git a/test-carddav.js b/test-carddav.js index e43de0a..c1a9a02 100644 --- a/test-carddav.js +++ b/test-carddav.js @@ -1844,5 +1844,55 @@ describe('CardDAV API Routes', () => { assert.ok(Array.isArray(res.data.data)); assert.strictEqual(res.data.data.length, 0); }); + + it('POST /accounts/:id/addressbooks/refresh - should refresh addressbooks', async () => { + const cardavRouter = await import('./server/routes/cardav.js'); + + // Create account first + const createReq = { + params: {}, + query: {}, + body: { + name: 'Refresh Test Account', + cardavUrl: 'https://example.com/carddav-refresh', + username: 'testuser-refresh', + password: 'testpass' + } + }; + const createRes = { + statusCode: 200, + status(code) { this.statusCode = code; return this; }, + json(data) { this.data = data; return this; }, + }; + + const postAccountHandler = cardavRouter.default.stack.find( + layer => layer.route?.path === '/accounts' && layer.route.methods.post + )?.route?.stack[0]?.handle; + + await postAccountHandler(createReq, createRes); + const accountId = createRes.data.data.account.id; + + // Refresh addressbooks + const req = { + params: { id: String(accountId) }, + query: {}, + body: {} + }; + const res = { + statusCode: 200, + status(code) { this.statusCode = code; return this; }, + json(data) { this.data = data; return this; }, + }; + + const refreshHandler = cardavRouter.default.stack.find( + layer => layer.route?.path === '/accounts/:id/addressbooks/refresh' && layer.route.methods.post + )?.route?.stack[0]?.handle; + + assert.ok(refreshHandler, 'POST /accounts/:id/addressbooks/refresh handler should exist'); + await refreshHandler(req, res); + + assert.strictEqual(res.statusCode, 200); + assert.ok(Array.isArray(res.data.data)); + }); }); });