feat(cardav): implement GET /accounts/:id/addressbooks endpoint

Add addressbook listing route. Queries carddav_addressbook_selection
table directly, ordered by name. Returns empty array if account has
no addressbooks.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Ulas Kalayci
2026-05-04 17:11:53 +02:00
parent 29646960fe
commit 12e8edf4c3
2 changed files with 106 additions and 0 deletions
+24
View File
@@ -103,4 +103,28 @@ router.post('/accounts/:id/test', async (req, res) => {
} }
}); });
/**
* GET /api/v1/contacts/cardav/accounts/:id/addressbooks
* Addressbooks für Account auflisten.
* Response: { data: Addressbook[] }
*/
router.get('/accounts/:id/addressbooks', async (req, res) => {
try {
const id = parseInt(req.params.id, 10);
if (!id || id < 1) return res.status(400).json({ error: 'Invalid ID', code: 400 });
const addressbooks = db.get().prepare(`
SELECT id, addressbook_url as url, addressbook_name as name, enabled
FROM carddav_addressbook_selection
WHERE account_id = ?
ORDER BY addressbook_name
`).all(id);
res.json({ data: addressbooks });
} catch (err) {
log.error('Error fetching addressbooks:', err);
res.status(500).json({ error: 'Interner Fehler', code: 500 });
}
});
export default router; export default router;
+82
View File
@@ -1762,5 +1762,87 @@ describe('CardDAV API Routes', () => {
assert.ok('ok' in res.data.data); assert.ok('ok' in res.data.data);
assert.ok(Array.isArray(res.data.data.addressbooks)); assert.ok(Array.isArray(res.data.data.addressbooks));
}); });
it('GET /accounts/:id/addressbooks - should list addressbooks', async () => {
const cardavRouter = await import('./server/routes/cardav.js');
// Create account first
const createReq = {
params: {},
query: {},
body: {
name: 'Addressbooks Test Account',
cardavUrl: 'https://example.com/carddav-ab',
username: 'testuser-ab',
password: 'testpass'
}
};
const createRes = {
statusCode: 200,
status(code) { this.statusCode = code; return this; },
json(data) { this.data = data; return this; },
};
const postAccountHandler = cardavRouter.default.stack.find(
layer => layer.route?.path === '/accounts' && layer.route.methods.post
)?.route?.stack[0]?.handle;
await postAccountHandler(createReq, createRes);
const accountId = createRes.data.data.account.id;
// Get addressbooks
const req = {
params: { id: String(accountId) },
query: {},
body: {}
};
const res = {
statusCode: 200,
status(code) { this.statusCode = code; return this; },
json(data) { this.data = data; return this; },
};
const getHandler = cardavRouter.default.stack.find(
layer => layer.route?.path === '/accounts/:id/addressbooks' && layer.route.methods.get
)?.route?.stack[0]?.handle;
assert.ok(getHandler, 'GET /accounts/:id/addressbooks handler should exist');
await getHandler(req, res);
assert.strictEqual(res.statusCode, 200);
assert.ok(Array.isArray(res.data.data));
if (res.data.data.length > 0) {
const ab = res.data.data[0];
assert.ok(ab.id);
assert.ok(ab.url);
assert.ok(ab.name);
assert.ok('enabled' in ab);
}
});
it('GET /accounts/:id/addressbooks - should return empty array when none', async () => {
const cardavRouter = await import('./server/routes/cardav.js');
const req = {
params: { id: '99999' },
query: {},
body: {}
};
const res = {
statusCode: 200,
status(code) { this.statusCode = code; return this; },
json(data) { this.data = data; return this; },
};
const getHandler = cardavRouter.default.stack.find(
layer => layer.route?.path === '/accounts/:id/addressbooks' && layer.route.methods.get
)?.route?.stack[0]?.handle;
await getHandler(req, res);
assert.strictEqual(res.statusCode, 200);
assert.ok(Array.isArray(res.data.data));
assert.strictEqual(res.data.data.length, 0);
});
}); });
}); });